Improve logging when there is failure to look up connection information

pull/16/head
brl 9 years ago
parent 2d2a269b53
commit dec08bce33

@ -32,6 +32,8 @@ type socketStatus struct {
uid int uid int
inode uint64 inode uint64
pid int pid int
// XXX debugging
line string
} }
func findProcessForPacket(pkt *nfqueue.Packet) *ProcInfo { func findProcessForPacket(pkt *nfqueue.Packet) *ProcInfo {
@ -142,24 +144,29 @@ func getSocketForPacket(pkt *nfqueue.Packet) *socketStatus {
return nil return nil
} }
pid := findPidForInode(ss.inode) pid := findPidForInode(ss.inode)
if pid == -1 { if pid > 0 {
return nil
}
ss.pid = pid ss.pid = pid
return ss return ss
} }
log.Info("Unable to find socket link socket:[%d] %s", ss.inode, printPacket(pkt, ""))
log.Info("Line was %s", ss.line)
return nil
}
func findSocket(pkt *nfqueue.Packet) *socketStatus { func findSocket(pkt *nfqueue.Packet) *socketStatus {
var status socketStatus var status socketStatus
for _, line := range getSocketLinesForPacket(pkt) { for _, line := range getSocketLinesForPacket(pkt) {
if len(line) == 0 {
continue
}
if err := status.parseLine(line); err != nil { if err := status.parseLine(line); err != nil {
log.Warning("Unable to parse line [%s]: %v", line, err) log.Warning("Unable to parse line [%s]: %v", line, err)
} else { } else if status.remote.ip.Equal(pkt.Dst) && status.remote.port == pkt.DstPort && status.local.ip.Equal(pkt.Src) && status.local.port == pkt.SrcPort {
if status.remote.ip.Equal(pkt.Dst) && status.remote.port == pkt.DstPort { status.line = line
return &status return &status
} }
} }
} log.Info("Failed to find socket for packet: %s", printPacket(pkt, ""))
return nil return nil
} }

Loading…
Cancel
Save